Improve handling of default values #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrueden
force-pushed
the
default-values
branch
from
20e63fa to
b1bfe66
Compare
This change leans on the new ModuleService#getDefaultValue(ModuleItem) method, which is smarter about default value computation across the board. It avoids the pitfall of bounding min/max using the widget model's min and max -- which fall back to the numeric type's min/max values for the purposes of bounding the widget -- and instead uses the ModuleItem's stated min/max, or a default converted from "0" if none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change leans on the new
ModuleService#getDefaultValue(ModuleItem)method, which is smarter about default value computation across the board. It avoids the pitfall of bounding min/max using the widget model's min and max—which fall back to the numeric type's min/max values for the purposes of bounding the widget—and instead uses theModuleItem's stated default/min/max, or a default converted from "0" if none.